Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue: vtctldclient/vtctld: Enhance test coverage and code refactor #16499

Open
rohit-nayak-ps opened this issue Jul 30, 2024 · 0 comments

Comments

@rohit-nayak-ps
Copy link
Contributor

rohit-nayak-ps commented Jul 30, 2024

Description

As part of the vtctldclient migration, we ported over a lot of existing code and wrote new code in the go/vt/vtctl/workflow package. However the unit test frameworks did not fully transition. While we have added some unit tests since, the current coverage is still very low.

Also we have ended up with some monolithic code, for example go/vt/vtctl/workflow.Server is the receiver for several helper functions. These can be extracted for better readability/maintability and to make it easier to cover in unit tests. There are also a few large functions that can benefit from method extraction and some object oriented-ness.

This is a tracking issue for reducing the current technical debt with both low level code and test coverage. Given that we have already deprecated vtctl and will be moving entirely to vtctld(client) soon we should address this sooner rather than later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In progress
Development

No branches or pull requests

1 participant