VReplication workflow package: unit tests for StreamMigrator, Mount et al

[rohit-nayak-ps]

Description

As part of the vtctldclient migration, we ported over a lot of existing code and wrote new code in the go/vt/vtctl/workflow package. However the unit test frameworks were not. While we have added some unit tests since, the current coverage is still very low.

This is one of multiple PRs that we will create to progressively increase coverage to a more acceptable level.

This PR has tests, among others, for:

• the Mount commands
• StreamMigrator
• ShardRoutingRules

Related Issue(s)

#16499

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.97%. Comparing base (471ab1a) to head (a1aba96).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16498      +/-   ##
==========================================
+ Coverage   68.87%   68.97%   +0.10%     
==========================================
  Files        1562     1562              
  Lines      200673   200673              
==========================================
+ Hits       138217   138423     +206     
+ Misses      62456    62250     -206     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mattlord]

❤️ Thank you for working on these!

[dbussink]

@rohit-nayak-ps Why not use https://pkg.go.dev/github.com/stretchr/testify/assert#Equal?

[rohit-nayak-ps]

Will change in the related followup PRs that improve coverage.