Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-17.0] BaseShowTablesWithSizes: optimize MySQL 8.0 query (#13375) #13390

Merged
merged 6 commits into from
Jun 28, 2023
Merged

[release-17.0] BaseShowTablesWithSizes: optimize MySQL 8.0 query (#13375) #13390

merged 6 commits into from
Jun 28, 2023

Conversation

vitess-bot[bot]
Copy link
Contributor

@vitess-bot vitess-bot bot commented Jun 27, 2023

Description

This is a backport of #13375.

@shlomi-noach
BaseShowTablesWithSizes: optimize MySQL 8.0 query
61354d7 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
adapt regular expression
451a14e 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
adapt regular expression, 2
558b758 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
refactored query again to combat the many unit test query format assu…
d4a1087 
…mptions

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
use t.table_schema in GROUP BY. Although not strictly necessary this …
5a95a57 
…may be faster

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@vitess-bot vitess-bot bot added Backport This is a backport Component: TabletManager Type: Performance NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jun 27, 2023
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Jun 27, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@shlomi-noach shlomi-noach requested a review from a team June 27, 2023 15:49
@shlomi-noach shlomi-noach self-assigned this Jun 27, 2023
@github-actions github-actions bot added this to the v17.0.1 milestone Jun 27, 2023
@shlomi-noach shlomi-noach removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Jun 27, 2023
@shlomi-noach shlomi-noach marked this pull request as draft June 28, 2023 07:15
@shlomi-noach shlomi-noach mentioned this pull request Jun 28, 2023
Merged
4 tasks
@shlomi-noach @systay
Support views in BaseShowTablesWithSizes for MySQL 8.0 (#13394)
1b89021 
* Support views in BaseShowTablesWithSizes for MySQL 8.0

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* added test

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* fixed test

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* schema tracker: use null safe comparison

Signed-off-by: Andres Taylor <andres@planetscale.com>

---------

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>
@shlomi-noach
Copy link
Contributor

cherry picked with #13394

@shlomi-noach shlomi-noach marked this pull request as ready for review June 28, 2023 10:41
@shlomi-noach shlomi-noach merged commit 12b425a into release-17.0 Jun 28, 2023
@shlomi-noach shlomi-noach deleted the backport-13375-to-release-17.0 branch June 28, 2023 17:09
@jjpersch jjpersch mentioned this pull request Sep 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlomi-noach shlomi-noach shlomi-noach approved these changes

@deepthi deepthi deepthi approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

Assignees

@shlomi-noach shlomi-noach

Labels
Backport This is a backport Component: TabletManager Type: Performance
Projects
None yet
Milestone
v17.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@shlomi-noach @deepthi