Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v15 backport: Onlineddl: formalize "immediate operations", respect --postpone-completion strategy flag #13832

Merged
merged 5 commits into from
Aug 28, 2023
Merged

v15 backport: Onlineddl: formalize "immediate operations", respect --postpone-completion strategy flag #13832

merged 5 commits into from
Aug 28, 2023

Commits on Aug 22, 2023

  1. Onlineddl: formalize "immediate operations", respect `--postpone-comp… 

    …letion` strategy flag (vitessio#11910)

* Added endtoend test to validate postponed REVERT of an ALTER VIEW statement: test indicates a bug

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* ALTER VIEW now respects --postpone-completion flag

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* Online DDL: formalize 'immediate operations', respect --postpone-completion

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* typo

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* only test instant ddl in capable versions (ie 8.0)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* more specific instant ddl capability

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* Update go/vt/vttablet/onlineddl/executor.go

Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* Update go/vt/vttablet/onlineddl/executor.go

Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* Update go/vt/vttablet/onlineddl/executor.go

Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com>
    @shlomi-noach @deepthi
    shlomi-noach and deepthi committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    24b9903 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Update go/vt/vttablet/onlineddl/executor.go 

    Co-authored-by: Andrew Mason <amason@hey.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach @ajm188
    shlomi-noach and ajm188 committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    a56d230 View commit details
    Browse the repository at this point in the history

  2. Removing a specific failing test from the backport. The removed test … 

    …tests '--prefer-instant-ddl', a functionality that was not backported to v15

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    a8cccdb View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. empty commit to kick ci 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    397eed2 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2023

  1. empty commit to kick ci 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    d569e70 View commit details
    Browse the repository at this point in the history