[release-15.0] Enable failures in tools/e2e_test_race.sh and fix races (#13654)
#14009
Commits on Sep 18, 2023
-
Enable failures in
tools/e2e_test_race.shand fix races (#13654)Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
-
Vttablet schema tracking: Fix _vt.schema_version corruption (#13045)
* Copy fields from schema.Engine before modifying This fixes a race condition which caused protobuf marshaled schema data in _vt.schema_version rows to become corrupted when ColumnType was modified between the time when Field message sizes were calculated and when Field message data was written to the buffer. Signed-off-by: Brendan Dougherty <brendan.dougherty@shopify.com> * Acquire schema engine mutex while marshaling schema This change is purely defensive, but it may help avoid future race conditions caused by modifying shared schema structs while they are being marshaled to protobuf. Signed-off-by: Brendan Dougherty <brendan.dougherty@shopify.com> * reorganize imports and allocate slices with make Signed-off-by: Austen Lacy <austen.lacy@shopify.com> * gofmt Signed-off-by: Austen Lacy <austen.lacy@shopify.com> * flakey unit test Signed-off-by: Austen Lacy <austen.lacy@shopify.com> * Use common code to update column_type for both vstreamer and rowstream events in a thread-safe fashion. Fix related tests Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Use DBName and not keyspace name while getting extended field info! Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Fix TestVStreamSharded Signed-off-by: Rohit Nayak <rohit@planetscale.com> --------- Signed-off-by: Brendan Dougherty <brendan.dougherty@shopify.com> Signed-off-by: Austen Lacy <austen.lacy@shopify.com> Signed-off-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: Austen Lacy <austen.lacy@shopify.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.