Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken link in docker readme #14222

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Fix broken link in docker readme #14222

merged 1 commit into from
Oct 12, 2023

Conversation

ravicodelabs
Copy link
Contributor

Description

This is a fix of a broken link in the docker readme. In particular, the third bullet under the "Principles" heading links to [lite/build.sh](https://github.com/vitessio/vitess/blob/main/docker/lite/build.sh, which does not exist, and is therefore substituted with another build.sh file link that works.

Related Issue(s)

Fixes #14221

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

@github-actions github-actions bot added this to the v19.0.0 milestone Oct 10, 2023
frouioui
frouioui approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thank you! However, the DCO check is failing, can you please amend your commit and sign it.

@ravicodelabs
Copy link
Contributor Author

This looks good to me, thank you! However, the DCO check is failing, can you please amend your commit and sign it.

Done!

@frouioui
Copy link
Member

Hey @ravicodelabs it seems like the DCO check is still failing. Please follow the instructions on https://github.com/vitessio/vitess/pull/14222/checks?check_run_id=17579049266.

@ravicodelabs ravicodelabs force-pushed the fix-link-in-docker-readme branch 2 times, most recently from 5d49941 to f4ccab0 Compare October 11, 2023 17:02
@ravicodelabs
Copy link
Contributor Author

Hi @frouioui, sorry for the back and forth! I've added the Signed-off-by line as well, so hopefully it should go through this time.

@frouioui
Copy link
Member

Hi @frouioui, sorry for the back and forth! I've added the Signed-off-by line as well, so hopefully it should go through this time.

It went through! Thank you 🙏🏻 We will get you a second review, and then we can merge this.

@ravicodelabs @frouioui
Fix broken link in docker readme
5a794db 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Copy link
Member

I force pushed to your branch @ravicodelabs to re-trigger CI as it was stuck for some reason.

@frouioui frouioui merged commit 71a732a into vitessio:main Oct 12, 2023
115 checks passed
@frouioui
Copy link
Member

Done @ravicodelabs, thank you for your contribution! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@deepthi deepthi deepthi approved these changes

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner

@dkhenry dkhenry Awaiting requested review from dkhenry

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

Assignees
No one assigned
Labels
Component: Documentation docs related issues/PRs Type: Internal Cleanup
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.

Bug Report: Broken link in docker readme
3 participants
@ravicodelabs @frouioui @deepthi