Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-17.0] Upgrade the Golang version to go1.20.10 #14229

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 10, 2023

This Pull Request bumps the Golang version to go1.20.10 and the bootstrap version to 18.4.

Do not trust the bot blindly. A thorough code review must be done to ensure all the files have been correctly modified.

There are a few manual steps remaining:

  • Make sure you update the Golang version used in the previous and next release branches for the Upgrade/Downgrade tests.
  • Build and Push the bootstrap images to Docker Hub, the bot cannot handle that.
  • Update the ./.github/workflows/*.yml files with the newer Golang version, the bot cannot handle that due to permissions.
    • To accomplish this, run the following: go run ./go/tools/go-upgrade/go-upgrade.go upgrade workflows --go-to=1.20.10

Signed-off-by: GitHub <noreply@github.com>
@github-actions github-actions bot added Benchmark me Add label to PR to run benchmarks Component: General Changes throughout the code base labels Oct 10, 2023
@github-actions github-actions bot added the go label Oct 10, 2023
@github-actions github-actions bot added the Skip CI Skip CI actions from running label Oct 10, 2023
@frouioui frouioui force-pushed the upgrade-go-to-1.20.10-on-release-17.0 branch from 57913cf to 124da49 Compare October 10, 2023 23:41
@frouioui frouioui removed the Skip CI Skip CI actions from running label Oct 10, 2023
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui force-pushed the upgrade-go-to-1.20.10-on-release-17.0 branch from 124da49 to e7b6b39 Compare October 11, 2023 00:54
@frouioui frouioui removed the Benchmark me Add label to PR to run benchmarks label Oct 11, 2023
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui merged commit ab53de3 into release-17.0 Oct 11, 2023
219 of 221 checks passed
@frouioui frouioui deleted the upgrade-go-to-1.20.10-on-release-17.0 branch October 11, 2023 17:42
@frouioui frouioui added this to the v17.0.4 milestone Oct 31, 2023
frouioui added a commit to planetscale/vitess that referenced this pull request Nov 21, 2023
….0] Upgrade the Golang version to `go1.20.10` (vitessio#3371)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: frouioui <frouioui@users.noreply.github.com>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: General Changes throughout the code base go Type: CI/Build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants