Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build and push Docker vitess/lite to DockerHub from GitHub Actions #14243

Merged
merged 11 commits into from
Oct 13, 2023
Merged

Build and push Docker vitess/lite to DockerHub from GitHub Actions #14243

merged 11 commits into from
Oct 13, 2023

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Oct 11, 2023 •
edited
Loading

Description

This PR adds automatic builds for the vitess/lite Docker Image on GitHub Actions instead of building them on DockerHub. An example of how the build works can be found below:

Note to self: remove DockerHub auto build once this is merged.

Note to reviewers: the new secrets have already been added to the repository.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

@frouioui
Build and push lite image to dockerhub from GitHub actions
cb6d64c 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 11, 2023 •
edited by deepthi
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 11, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Oct 11, 2023
@frouioui
Build and push lite image
c76211e 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Fix conditional syntax
5494601 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
remove conditional and set Dockerfile + Docker Tag ahead of time
ed7b51b 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
wip allow the workflow to run on any repository for test purposes
7445bf9 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Remove unwanted double git checkout
c84167f 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
remove unrequired steps in workflow
6fe4e61 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
checkout and use proper context
62efe55 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
build and push on frouioui for testing
fb0ead1 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
build and push on frouioui for testing
9c758ae 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Docker and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Oct 12, 2023
@frouioui frouioui changed the title Build and push Docker Images to DockerHub from GitHub Actions Build and push Docker vitess/lite to DockerHub from GitHub Actions Oct 12, 2023
@frouioui
remove all wip
bbde6f8 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui marked this pull request as ready for review October 12, 2023 23:33
@frouioui frouioui mentioned this pull request Oct 12, 2023
Merged
4 tasks
mattlord
mattlord approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for working on this! ❤️ Nice work 🙂

@frouioui frouioui merged commit 1f1d731 into vitessio:main Oct 13, 2023
115 checks passed
@frouioui frouioui deleted the docker-build-in-ci branch October 13, 2023 18:47
@frouioui frouioui mentioned this pull request Nov 13, 2023
Merged
frouioui added a commit that referenced this pull request Nov 13, 2023
@frouioui
Build and push Docker vitess/lite to DockerHub from GitHub Actions (#…
6f47eb9 
…14243)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui added a commit to planetscale/vitess that referenced this pull request Nov 13, 2023
@frouioui
Build and push Docker vitess/lite to DockerHub from GitHub Actions (v…
561b878 
…itessio#14243)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui mentioned this pull request Nov 13, 2023
Merged
frouioui added a commit to planetscale/vitess that referenced this pull request Nov 13, 2023
@frouioui
Build and push Docker vitess/lite to DockerHub from GitHub Actions (v…
f306e80 
…itessio#14243)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui mentioned this pull request Nov 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattlord mattlord mattlord approved these changes

@deepthi deepthi deepthi approved these changes

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

Assignees
No one assigned
Labels
Component: Docker Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@frouioui @deepthi @mattlord