Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi Table Delete Support: join with reference table #14784

Merged
merged 14 commits into from
Dec 20, 2023
Merged

Multi Table Delete Support: join with reference table #14784

merged 14 commits into from
Dec 20, 2023

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Dec 14, 2023 •
edited
Loading

Description

This PR is an initial PR towards supporting multi table delete. This PR adds support for single target delete with table references with sharded and reference table.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Dec 14, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 14, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Dec 14, 2023
@harshit-gangal
updated analyzer to add early rewriter to add target to update statem…
a337b58 
…ent and binder to bind target to tableID

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
ignore target in ast format if single alias table expr
b664f43 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
added semantics test and changed target binding on TableNames visit
bdf01ea 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@systay systay force-pushed the multi-tbl-delete branch 2 times, most recently from 9af89a8 to 39bcd53 Compare December 15, 2023 10:27
@harshit-gangal
delete planning to use query graph and sql builder with push down del…
2da13e9 
…ete logic

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
plan foreign key with new delete operator
2de858c 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
allow limit with destination for delete
da94286 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
feat: single target multiple tables in table references
3064158 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
error out for unsupported cases
e5b41a4 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Dec 19, 2023
@harshit-gangal
Merge remote-tracking branch 'upstream/main' into multi-tbl-delete
a863f0f 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal marked this pull request as ready for review December 19, 2023 09:12
@harshit-gangal harshit-gangal changed the title Multi Table Delete Initial Multi Table Delete Support Dec 19, 2023
@harshit-gangal harshit-gangal changed the title Initial Multi Table Delete Support Multi Table Delete Support: join with reference table Dec 19, 2023
@harshit-gangal
fix test expectation
cccd09a 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
GuptaManan100
GuptaManan100 approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks good to me

go/vt/vtgate/planbuilder/operator_transformers.go
dmlOp operators.Operator,
hints *queryHints,
) (logicalPlan, error) {
func buildDeleteLogicalPlan(ctx *plancontext.PlanningContext, rb *operators.Route, dmlOp operators.Operator, stmt *sqlparser.Delete, hints *queryHints) (logicalPlan, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we adding stmt to the function call, if we already have the ast in del.AST

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, I found the answer looking at the code further, you removed the AST from the delete operator

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we can put the arguments on multiple lines as it was before

go/vt/vtgate/planbuilder/operators/SQL_builder.go Outdated
Comment on lines 387 to 394
func buildDelete(op *Delete, qb *queryBuilder) {
buildQuery(op.Source, qb)
qb.dmlOperator = op

sel, ok := qb.stmt.(*sqlparser.Select)
if !ok {
panic(vterrors.VT13001("expected a select here"))
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have a comment explaining why the Delete's source has to result in a select query in the buildQuery call. I understand why, but it took me a while too. Having a comment would be nice for future reference.

@harshit-gangal
check for targets count for formatting
5143c86 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
address review comment
0a4bfe2 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
Merge remote-tracking branch 'upstream/main' into multi-tbl-delete
49ff3ce 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
fix test
1c388b3 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
frouioui
frouioui reviewed Dec 20, 2023
View reviewed changes
go/vt/sqlparser/ast_funcs.go
Comment on lines +2545 to +2550
if len(node.Targets) > 1 {
return false
}
if len(node.TableExprs) != 1 {
return false
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: you can move these two conditions into a single if

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will make the change in the next PR.

frouioui
frouioui reviewed Dec 20, 2023
View reviewed changes
go/vt/vtgate/planbuilder/delete.go
Comment on lines -148 to +147
multiShardErr := vterrors.VT12001("multi-shard or vindex write statement")
if len(del.TableExprs) != 1 {
return multiShardErr
}
_, isAliasedExpr := del.TableExprs[0].(*sqlparser.AliasedTableExpr)
if !isAliasedExpr {
return multiShardErr
}

// Delete is only supported for single Target.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can there be no target at all?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there there is no nothing to delete. So, one target is a must.

@harshit-gangal harshit-gangal merged commit ed5e67f into vitessio:main Dec 20, 2023
104 checks passed
@harshit-gangal harshit-gangal deleted the multi-tbl-delete branch December 20, 2023 08:08
ejortegau pushed a commit to slackhq/vitess that referenced this pull request Jan 24, 2024
@harshit-gangal @ejortegau
Multi Table Delete Support: join with reference table (vitessio#14784)
1d581c1 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Eduardo J. Ortega U. <5791035+ejortegau@users.noreply.github.com>
systay pushed a commit that referenced this pull request Jul 22, 2024
@planetscale-actions-bot @harshit-gangal
CherryPick(#14784): Multi Table Delete Support: join with reference t…
12f39e9 
…able (#4007)

* cherry pick of 14784

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>

* fix: build on delete operator (#14833)

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

---------

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Co-authored-by: Harshit Gangal <harshit@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@systay systay Awaiting requested review from systay systay is a code owner

@arthurschreiber arthurschreiber Awaiting requested review from arthurschreiber arthurschreiber is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Feature
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.

Feature request: 'multi-shard or vindex write statement' with reference tables should/could work
3 participants
@harshit-gangal @frouioui @GuptaManan100