Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-17.0] Upgrade Golang from v1.20.13 to v1.21.9 #15669

Merged
merged 5 commits into from
Apr 9, 2024
Merged

[release-17.0] Upgrade Golang from v1.20.13 to v1.21.9 #15669

merged 5 commits into from
Apr 9, 2024

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Apr 4, 2024

Description

We usually do not upgrade the minor version of Golang on release branches such as release-17.0. However, Vitess and Golang share an almost-overlapping release cycle: the two projects support their versions for one year, but Golang does 2 releases a year, and we do 3. Leading to some releases of Vitess using an unsupported Go version for some time until they EOL.

Given that v17.0.0 was released in June 2023 and go1.20 was EOL on February 2024, and using the old way of not upgrading the minor go version on release branches, v17 would have used an unsupported version of Go for about 4 months until it EOLs.

This Pull Request upgrades the Go version to go1.21.9 to ensure we stay up-to-date with all the security fixes and patches the Go team is producing.

Related Issue(s)

@frouioui
Bump to go 1.21.9
f02698e 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Bump golang.org/x/net to 0.24.0
185cd31 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Apr 4, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Apr 4, 2024
@frouioui frouioui removed NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work labels Apr 4, 2024
@github-actions github-actions bot added this to the v17.0.7 milestone Apr 4, 2024
@frouioui frouioui mentioned this pull request Apr 4, 2024
Closed
5 tasks
@frouioui frouioui added Type: CI/Build Component: General Changes throughout the code base labels Apr 4, 2024
@frouioui
Remove extra char in file
09c6873 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Fix tls tests
8228c8f 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Re-gen workflows
bcec3fc 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui added the Benchmark me Add label to PR to run benchmarks label Apr 4, 2024
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Apr 4, 2024

Hello! 👋

This Pull Request is now handled by arewefastyet. The current HEAD and future commits will be benchmarked.

You can find the performance comparison on the arewefastyet website.

deepthi
deepthi approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's double check and make sure no other updates are needed to dependencies in go.mod before merging.

@deepthi deepthi merged commit 1d4f195 into vitessio:release-17.0 Apr 9, 2024
102 checks passed
@deepthi deepthi deleted the bump-go-release-17.0-1.21 branch April 9, 2024 05:24
@deepthi
Copy link
Member

deepthi commented Apr 9, 2024

Merging this now, though we need to still look at benchmark results before doing another patch release.

notfelineit pushed a commit to planetscale/vitess that referenced this pull request Apr 13, 2024
@deepthi @frouioui
@dbussink @GuptaManan100
[latest-17.0] upgrade to go 1.21.9 (vitessio#4912)
2ebcc41 
* Upgrade go version in upgrade tests to `go1.21.9` (vitessio#15640)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: deepthi <deepthi@planetscale.com>

* Upgrade Golang from `v1.20.13` to `v1.21.9` (vitessio#15669)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: deepthi <deepthi@planetscale.com>

* match go version on base image with go.mod

Signed-off-by: deepthi <deepthi@planetscale.com>

* Update additional jobs

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>

* fix unit test

Signed-off-by: deepthi <deepthi@planetscale.com>

* test: fix template file too

Signed-off-by: Manan Gupta <manan@planetscale.com>

* test: remove usage of a function that doesn't exist

Signed-off-by: Manan Gupta <manan@planetscale.com>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlomi-noach shlomi-noach shlomi-noach approved these changes

@mattlord mattlord mattlord approved these changes

@deepthi deepthi deepthi approved these changes

@dbussink dbussink dbussink approved these changes

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner

@dkhenry dkhenry Awaiting requested review from dkhenry

@ajm188 ajm188 Awaiting requested review from ajm188 ajm188 is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

Assignees
No one assigned
Labels
Benchmark me Add label to PR to run benchmarks Component: General Changes throughout the code base Type: CI/Build
Projects
None yet
Milestone
v17.0.7
Development

Successfully merging this pull request may close these issues.
5 participants
@frouioui @deepthi @dbussink @mattlord @shlomi-noach