-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix panic in aggregation #15728
Merged
GuptaManan100
merged 4 commits into
vitessio:main
from
GuptaManan100:fix-panic-aggregation
Apr 17, 2024
Merged
Fix panic in aggregation #15728
GuptaManan100
merged 4 commits into
vitessio:main
from
GuptaManan100:fix-panic-aggregation
Apr 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manan Gupta <manan@planetscale.com>
…these functions Signed-off-by: Manan Gupta <manan@planetscale.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Apr 17, 2024
Signed-off-by: Manan Gupta <manan@planetscale.com>
systay
approved these changes
Apr 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15728 +/- ##
==========================================
- Coverage 68.40% 68.39% -0.01%
==========================================
Files 1556 1556
Lines 195121 195347 +226
==========================================
+ Hits 133479 133617 +138
- Misses 61642 61730 +88 ☔ View full report in Codecov by Sentry. |
systay
added
Type: Bug
Component: Query Serving
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Apr 17, 2024
Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100
requested review from
harshit-gangal,
frouioui and
deepthi
as code owners
April 17, 2024 08:09
GuptaManan100
removed
the
NeedsIssue
A linked issue is missing for this Pull Request
label
Apr 17, 2024
Can this be backported to v19? |
systay
added
Backport to: release-18.0
Needs to be back ported to release-18.0
Backport to: release-19.0
Needs to be back ported to release-19.0
labels
Apr 17, 2024
frouioui
approved these changes
Apr 17, 2024
vitess-bot
pushed a commit
that referenced
this pull request
Apr 17, 2024
Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100
added a commit
that referenced
this pull request
Apr 17, 2024
Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100
added a commit
that referenced
this pull request
Apr 18, 2024
GuptaManan100
added a commit
that referenced
this pull request
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport to: release-18.0
Needs to be back ported to release-18.0
Backport to: release-19.0
Needs to be back ported to release-19.0
Component: Query Serving
Type: Bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the aggregation engine, we need to have full field information from the inputs to calculate things correctly.
This PR makes sure that the aggregator always asks for fields. When it was running inside of some other operators that don't need fields, we failed to ask for the fields, and this could lead to panics.
Related Issue(s)
Checklist