-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare schema tracking for all UDFs #15732
Conversation
Signed-off-by: Andres Taylor <andres@planetscale.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Andres Taylor <andres@planetscale.com>
77f2c7f
to
a415863
Compare
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
18d7594
to
965a647
Compare
Signed-off-by: Andres Taylor <andres@planetscale.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15732 +/- ##
==========================================
+ Coverage 68.38% 68.41% +0.02%
==========================================
Files 1556 1556
Lines 195361 195418 +57
==========================================
+ Hits 133598 133695 +97
+ Misses 61763 61723 -40 ☔ View full report in Codecov by Sentry. |
type UDF struct { | ||
Name string | ||
Aggregating bool | ||
Type querypb.Type | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks unused.
Signed-off-by: Andres Taylor <andres@planetscale.com>
Description
We recently added support for UDFs to the schema tracker. This PR tweaks the gRPC APIs used to make them easier to grow with. We know we want to track types from UDFs in a not-too-distant future, so we might as well prepare the tracker and the gRPC apis to allow for that. This way we don't have the issue with mismatched versions between the vtgate and the vttablet when upgrading.
Related Issue(s)
First attempt: #15705
Planner changes: #15710
Checklist