Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert GRPC context changes #15780

Merged

Commits on Apr 23, 2024

  1. Revert GRPC context changes

    These changes were made assuming we could use `grpc.NewClient`
    everywhere. But we had failing test for that. In a specific case, we
    replace it with `grpc.Dial` but that's not the same.
    
    If we can't move it all to `grpc.NewClient` yet, we have to keep the
    context setup we do as well, or otherwise `grpc.Dial` could hang
    indefinitely even if the caller context is cancelled since it gets
    started with the background context.
    
    Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
    dbussink committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    4736a0e View commit details
    Browse the repository at this point in the history