Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evalengine: Add support for enum and set #15783

Merged

Commits on Apr 23, 2024

  1. evalengine: Add support for enum and set

    The evalengine currently doesn't handle enum and set types properly.
    The comparison function always returns 0 at the moment and we don't
    consider ordering of elements etc.
    
    Here we add two new native types to the evalengine for set and enum and
    instantiate those appropriately. We also ensure we can compare them
    correctly.
    
    In case we don't have the schema information with the values, we do a
    best effort case of depending on the string representation. This is not
    correct always of course, but at least makes equality comparison work
    for those cases and only ordering is off in that scenario.
    
    Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
    dbussink committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    b0521ad View commit details
    Browse the repository at this point in the history
  2. Introduce type and use pointer to reduce size

    Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
    dbussink committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    595ec8f View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Fix comments

    Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
    dbussink committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    89ffe52 View commit details
    Browse the repository at this point in the history