Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Scale and length handling in CASE and JOIN bind variables #15787

Merged
merged 6 commits into from
Apr 25, 2024
Merged

Fix Scale and length handling in CASE and JOIN bind variables #15787

merged 6 commits into from
Apr 25, 2024

Commits on Apr 24, 2024

  1. feat: add failing case test and fix it 

    Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    f422372 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into tpch-case-problem 

    Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    aae6b16 View commit details
    Browse the repository at this point in the history

  3. refactor: address review comments 

    Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    e65487d View commit details
    Browse the repository at this point in the history

  4. refactor: move scale and size calculation inside type aggregation 

    Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    4786466 View commit details
    Browse the repository at this point in the history

  5. Fix crash and handle datetime size correctly 

    Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
    @dbussink
    dbussink committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    0ec0c78 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. refactor: split the line into multiple parts for readability 

    Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    94fe5b1 View commit details
    Browse the repository at this point in the history