Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-18.0] Direct PR. Fix regression where reference tables with a different name on sharded keyspaces were not routed correctly. #15788

Merged
merged 11 commits into from
May 7, 2024
Merged

[release-18.0] Direct PR. Fix regression where reference tables with a different name on sharded keyspaces were not routed correctly. #15788

merged 11 commits into from
May 7, 2024

Commits on Apr 24, 2024

  1. Adding e2e test to repro error with reference table routing 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    d325cc1 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Update e2e test to test dmls addressing the reference table differently 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    f564ef3 View commit details
    Browse the repository at this point in the history

  2. Update table rerouting to account for reference tables 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    363f90d View commit details
    Browse the repository at this point in the history

  3. Add test cases for insert/update/delete rerouting for reference tables 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    237cdfc View commit details
    Browse the repository at this point in the history

  4. Revert onecase.json. Add separate test case/file for this PR 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    8ad019e View commit details
    Browse the repository at this point in the history

  5. Add cases for select with reference tables 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    416f2d4 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Refactor and revert unnecessary code/changes 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    679e3fd View commit details
    Browse the repository at this point in the history

  2. Address review comments. Move tests into reference_cases.json and rem… 

    …ove additional test

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    cf3cf6c View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Simplify logic for handling reference tables with different names. Ad… 

    …d test cases for aliases

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed May 1, 2024
    Configuration menu
    Copy the full SHA
    89a8ebe View commit details
    Browse the repository at this point in the history

  2. Improve comments 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed May 1, 2024
    Configuration menu
    Copy the full SHA
    3ed27d0 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Add license header 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed May 6, 2024
    Configuration menu
    Copy the full SHA
    91d5865 View commit details
    Browse the repository at this point in the history