Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for Insert with row alias #15790

Merged
merged 8 commits into from
Apr 29, 2024
Merged

feat: Add support for Insert with row alias #15790

merged 8 commits into from
Apr 29, 2024

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Apr 25, 2024 •
edited
Loading

Description

This adds planner support for new insert syntax
insert into t(id, col) values(1, 'apa') as dt(x) on duplicate key col = x

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@systay
feat: handle INSERT with RowAlias
464ed1a 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Apr 25, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Apr 25, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Apr 25, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.70629% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 68.44%. Comparing base (96b1419) to head (d1c396b).
Report is 6 commits behind head on main.

Files Patch % Lines
go/vt/vtgate/semantics/table_collector.go 92.78% 7 Missing ⚠️
go/vt/vtgate/engine/insert.go 87.50% 1 Missing ⚠️
go/vt/vtgate/semantics/vtable.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15790      +/-   ##
==========================================
- Coverage   68.44%   68.44%   -0.01%     
==========================================
  Files        1558     1558              
  Lines      195822   196129     +307     
==========================================
+ Hits       134032   134233     +201     
- Misses      61790    61896     +106

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harshit-gangal harshit-gangal added Type: Feature Component: Query Serving release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Apr 25, 2024
@harshit-gangal
handle invisible columns for insert derived table column list
c0bc78a 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
return error instead of panic for wrong column counts
f710bc9 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@vitess-bot vitess-bot bot mentioned this pull request Apr 25, 2024
Merged
@harshit-gangal
notes: added release notes
f9a607c 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal removed the release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) label Apr 25, 2024
@harshit-gangal harshit-gangal marked this pull request as ready for review April 25, 2024 16:09
@harshit-gangal
fix: insert sharded query to include alias in the formatted query
70e2114 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
test: skip test for vttablet and vtgate not on v20
5b43495 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
sizgen run
e7782d1 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
split the rowalias table collector method to smaller methods
d1c396b 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
GuptaManan100
GuptaManan100 approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks good to me!

go/vt/vtgate/engine/insert.go
Comment on lines +369 to +381
// This is a check to ensure we send the correct query to the database.
// "ActualQuery" should not be part of the plan output, if it does, it means the query was not rewritten correctly.
if ins.Mid != nil {
var mids []string
for _, n := range ins.Mid {
mids = append(mids, sqlparser.String(n))
}
shardedQuery := ins.Prefix + strings.Join(mids, ", ") + ins.Alias + sqlparser.String(ins.Suffix)
if shardedQuery != ins.Query {
other["ActualQuery"] = shardedQuery
}
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this code intended for debugging to see when the sharded query and the original query are different?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept this for a reason to fail in future if anything goes wrong in the final query output.

@harshit-gangal harshit-gangal merged commit ca2659d into vitessio:main Apr 29, 2024
104 checks passed
@harshit-gangal harshit-gangal deleted the insert-as branch April 29, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@systay systay systay approved these changes

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@arthurschreiber arthurschreiber Awaiting requested review from arthurschreiber arthurschreiber is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Feature
Projects
None yet
Milestone
v20.0.0
Development

Successfully merging this pull request may close these issues.

Bug Report: Syntax error near 'AS'
3 participants
@harshit-gangal @systay @GuptaManan100