Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to use semisync source / replica plugins #15791

Merged
merged 2 commits into from
Apr 26, 2024

Fix test assertions

500a31f
Select commit
Loading
Failed to load commit list.
Merged

Switch to use semisync source / replica plugins #15791

Fix test assertions
500a31f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 26, 2024 in 1s

68.44% (+0.00%) compared to ee6b837

View this Pull Request on Codecov

68.44% (+0.00%) compared to ee6b837

Details

Codecov Report

Attention: Patch coverage is 50.65789% with 75 lines in your changes are missing coverage. Please review.

Project coverage is 68.44%. Comparing base (ee6b837) to head (500a31f).

Files Patch % Lines
go/vt/mysqlctl/replication.go 68.00% 24 Missing ⚠️
go/vt/vttablet/tabletmanager/rpc_replication.go 18.51% 22 Missing ⚠️
go/vt/mysqlctl/mysqld.go 0.00% 6 Missing ⚠️
go/cmd/vtcombo/cli/main.go 0.00% 5 Missing ⚠️
go/mysql/flavor_mysql.go 37.50% 5 Missing ⚠️
go/vt/mysqlctl/fakemysqldaemon.go 50.00% 4 Missing ⚠️
go/vt/vttablet/tabletmanager/rpc_actions.go 57.14% 3 Missing ⚠️
go/mysql/flavor_mariadb.go 0.00% 2 Missing ⚠️
go/mysql/replication.go 77.77% 2 Missing ⚠️
go/vt/mysqlctl/builtinbackupengine.go 50.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #15791   +/-   ##
=======================================
  Coverage   68.43%   68.44%           
=======================================
  Files        1558     1558           
  Lines      195971   196036   +65     
=======================================
+ Hits       134121   134169   +48     
- Misses      61850    61867   +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov