-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
projection: Return correct collation information #15801
Conversation
When we have a project, we correctly convert the value to the connection collation using: ```go c.Value(vcursor.ConnCollation()) ``` But we then don't update / change the collation on the fields information. This needs to match the actual data, otherwise the client might corrupt the data. This ensures we add the same rules for the resulting collation. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Marked this for back porting, since this can lead to the clients corrupting data / interpreting it as wrongly encoded information and could unexpectedly error out. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15801 +/- ##
==========================================
- Coverage 68.42% 68.42% -0.01%
==========================================
Files 1558 1558
Lines 196036 196039 +3
==========================================
+ Hits 134136 134137 +1
- Misses 61900 61902 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
…) (#15804) Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>
When we have a project, we correctly convert the value to the connection collation using:
But we then don't update / change the collation on the fields information. This needs to match the actual data, otherwise the client might corrupt the data.
This ensures we add the same rules for the resulting collation.
Related Issue(s)
Fixes #15800
Checklist