Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-19.0] Backport testing for new semi-sync plugin #15806

Closed
wants to merge 2 commits into from
Closed

[release-19.0] Backport testing for new semi-sync plugin #15806

wants to merge 2 commits into from

Conversation

dbussink
Copy link
Contributor

There are upgrade / downgrade tests that run against a newer version from main on the release-19.0 branch. That means those have the new plugin loaded and these endtoend tests need to be able to check both also for the release-19.0 branch.

Related Issue(s)

See also the failures in #15804

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

@dbussink
[release-19.0] Backport testing for new semi-sync plugin
28f576f 
There are upgrade / downgrade tests that run against a newer version
from `main` on the `release-19.0` branch. That means those have the new
plugin loaded and these endtoend tests need to be able to check both
also for the `release-19.0` branch.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@dbussink dbussink requested a review from deepthi as a code owner April 26, 2024 20:37
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Apr 26, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Apr 26, 2024
@github-actions github-actions bot added this to the v19.0.4 milestone Apr 26, 2024
@dbussink dbussink added Type: Bug Type: Testing Component: General Changes throughout the code base and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Apr 26, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.45%. Comparing base (e04b73c) to head (0cdf269).

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-19.0   #15806      +/-   ##
================================================
- Coverage         67.45%   67.45%   -0.01%     
================================================
  Files              1560     1560              
  Lines            192777   192777              
================================================
- Hits             130041   130040       -1     
- Misses            62736    62737       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

deepthi
deepthi approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, we deal with upgrade/downgrade tests by writing code that is conditional on the binary version. This implementation is fine though because it will actually work on older versions of Vitess/MySQL as well.

go/test/endtoend/reparent/utils/utils.go Outdated
@@ -669,30 +680,60 @@ func assertNodeCount(t *testing.T, result string, want int) {
assert.Equal(t, want, got)
}

// CheckDBvar checks the db var
func CheckDBvar(ctx context.Context, t *testing.T, tablet *cluster.Vttablet, variable string, status string) {
func CheckSemisyncEnabled(ctx context.Context, t *testing.T, tablet *cluster.Vttablet, enabled bool) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
func CheckSemisyncEnabled(ctx context.Context, t *testing.T, tablet *cluster.Vttablet, enabled bool) {
func CheckSemiSyncEnabled(ctx context.Context, t *testing.T, tablet *cluster.Vttablet, enabled bool) {

go/test/endtoend/reparent/utils/utils.go Outdated
}

// CheckDBstatus checks the db status
func CheckDBstatus(ctx context.Context, t *testing.T, tablet *cluster.Vttablet, variable string, status string) {
func CheckSemisyncStatus(ctx context.Context, t *testing.T, tablet *cluster.Vttablet, enabled bool) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
func CheckSemisyncStatus(ctx context.Context, t *testing.T, tablet *cluster.Vttablet, enabled bool) {
func CheckSemiSyncStatus(ctx context.Context, t *testing.T, tablet *cluster.Vttablet, enabled bool) {

@dbussink
Fix naming
0cdf269 
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@dbussink
Copy link
Contributor Author

Added to #15804 since it's causing issues there too and we want to merge that one anyway.

@dbussink dbussink closed this Apr 27, 2024
@dbussink dbussink deleted the backport-replica-plugin-tests branch April 27, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100

Assignees
No one assigned
Labels
Component: General Changes throughout the code base Type: Bug Type: Testing
Projects
None yet
Milestone
v19.0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@dbussink @deepthi