Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VTAdmin] Remove vtctld web link, improve local example (#15607) #15824

Merged

Conversation

notfelineit
Copy link
Contributor

This PR is the cherry-pick of #15607

Description

This PR:

  • Removes the link to vtctld web, since we deprecated it in v17
  • Improves vtadmin-up.sh by 1) outputting the variables that are being set and 2) shortening the wait time for cluster discovery
  • Improves web/vtadmin/build.sh by 1) outputting the variables set and 2) when no hostname is set, uses the local machine's hostname

The last bullet point made it so that I could run ./101_initial_clusters.sh without any extra steps, and get vtadmin-web/vtadmin-api working:

Screenshot 2024-04-01 at 6 14 19 PM

Copy link
Contributor

vitess-bot bot commented May 1, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels May 1, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone May 1, 2024
Signed-off-by: notfelineit <notfelineit@gmail.com>
@notfelineit notfelineit changed the base branch from main to release-19.0 May 1, 2024 03:03
@notfelineit notfelineit changed the title Cherry pick PR 15607 to v19 [VTAdmin] Remove vtctld web link, improve local example (#15607) May 1, 2024
@deepthi deepthi removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels May 1, 2024
@deepthi
Copy link
Member

deepthi commented May 1, 2024

Seems like the code owners on this branch is messed up. There is no need for all the people tagged on this PR to be reviewers.

Signed-off-by: notfelineit <notfelineit@gmail.com>
@notfelineit notfelineit merged commit 2c42825 into vitessio:release-19.0 May 2, 2024
103 checks passed
@notfelineit notfelineit deleted the cherry-pick-15607-to-19 branch May 2, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants