-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schemadiff
: atomic diffs for range partition DROP PARTITION
statement
#15843
schemadiff
: atomic diffs for range partition DROP PARTITION
statement
#15843
Conversation
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's start here and we can further look into what else we want to split up for AtomicDiffs
. I suspect there's probably some more cases where it's useful but we can do that in a separate change.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15843 +/- ##
==========================================
+ Coverage 68.40% 68.46% +0.05%
==========================================
Files 1556 1559 +3
Lines 195121 196592 +1471
==========================================
+ Hits 133479 134589 +1110
- Misses 61642 62003 +361 ☔ View full report in Codecov by Sentry. |
Description
Introducing a
AtomicDiffs()
function, which, given a single diff, returns a slice of diffs, as atomic as possible, which together comprises the given diff.Right now the function only breaks down
DROP PARTITION
statements.An an aside, this PR also adds a convenient
Clone()
function toEntityDiff
interface, which does a deep copy of the diff and of its entities (but not necessarily other constructs such as annotations). This is useful for programs usingschemadiff
as a library as it allows some safety for data manipulation.Related Issue(s)
Addresses #15842
Checklist
Deployment Notes