Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysqlctl: Improve backup restore compatibility check #15856

Merged

Conversation

dbussink
Copy link
Contributor

@dbussink dbussink commented May 7, 2024

This check has to be smarter to allow certain backup restore scenarios. Starting from MySQL 8.0.35, it's allowed to restore into older versions within the same LTS stream. This is something we didn't allow so far, but we need to for managing the more recent MySQL releases correctly.

This also implies that we don't need upgrade safe flags for these cases as well and allows it even if that flag is off now.

Related Issue(s)

Fixes #15855

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

This check has to be smarter to allow certain backup restore scenarios.
Starting from MySQL 8.0.35, it's allowed to restore into older versions
within the same LTS stream. This is something we didn't allow so far,
but we need to for managing the more recent MySQL releases correctly.

This also implies that we don't need upgrade safe flags for these cases
as well and allows it even if that flag is off now.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Copy link
Contributor

vitess-bot bot commented May 7, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels May 7, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone May 7, 2024
@dbussink dbussink added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Backup and Restore and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels May 7, 2024
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 68.44%. Comparing base (f118ba2) to head (6472ee0).
Report is 64 commits behind head on main.

Files Patch % Lines
go/vt/mysqlctl/backupengine.go 82.35% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15856      +/-   ##
==========================================
+ Coverage   68.40%   68.44%   +0.03%     
==========================================
  Files        1556     1559       +3     
  Lines      195121   196535    +1414     
==========================================
+ Hits       133479   134519    +1040     
- Misses      61642    62016     +374     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbussink
Copy link
Contributor Author

dbussink commented May 7, 2024

See also mysql/mysql-server@9a940ab which encodes in MySQL itself.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
go/vt/mysqlctl/backupengine_test.go Outdated Show resolved Hide resolved
go/vt/mysqlctl/version.go Outdated Show resolved Hide resolved
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@dbussink dbussink merged commit 0d7af14 into vitessio:main May 7, 2024
93 checks passed
@dbussink dbussink deleted the dbussink/fix-backup-restore-upgrade-check branch May 7, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Backup and Restore Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Restores should be possible for MySQL 8.0.35+ where version checks are relaxed
3 participants