-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mysqlctl: Improve backup restore compatibility check #15856
mysqlctl: Improve backup restore compatibility check #15856
Conversation
This check has to be smarter to allow certain backup restore scenarios. Starting from MySQL 8.0.35, it's allowed to restore into older versions within the same LTS stream. This is something we didn't allow so far, but we need to for managing the more recent MySQL releases correctly. This also implies that we don't need upgrade safe flags for these cases as well and allows it even if that flag is off now. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15856 +/- ##
==========================================
+ Coverage 68.40% 68.44% +0.03%
==========================================
Files 1556 1559 +3
Lines 195121 196535 +1414
==========================================
+ Hits 133479 134519 +1040
- Misses 61642 62016 +374 ☔ View full report in Codecov by Sentry. |
See also mysql/mysql-server@9a940ab which encodes in MySQL itself. |
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
This check has to be smarter to allow certain backup restore scenarios. Starting from MySQL 8.0.35, it's allowed to restore into older versions within the same LTS stream. This is something we didn't allow so far, but we need to for managing the more recent MySQL releases correctly.
This also implies that we don't need upgrade safe flags for these cases as well and allows it even if that flag is off now.
Related Issue(s)
Fixes #15855
Checklist