-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong assignment to sql_id_opt
in the parser
#15862
Conversation
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15862 +/- ##
==========================================
- Coverage 68.44% 68.42% -0.02%
==========================================
Files 1559 1559
Lines 196537 196537
==========================================
- Hits 134522 134484 -38
- Misses 62015 62053 +38 ☔ View full report in Codecov by Sentry. |
@@ -5646,6 +5646,7 @@ window_partition_clause_opt: | |||
|
|||
sql_id_opt: | |||
{ | |||
$$ = IdentifierCI{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is an empty block in the parser in general a signal for a bug? And if so, do we have more cases like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@systay tried to simplify the query to a minimum but that was the only way to trigger the bug AFAIK
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Description
This PR fixes #15861 by not reusing an old value on the
sql_id_opt
field when parsingwindow_spec
.Backporting this to all release branches as the issue exist in all of them.
Related Issue(s)
WindowSpecification
leads to extra column in AST #15861Checklist
Deployment Notes