[release-17.0] Upgrade the Golang version to go1.21.10

[vitess-bot]

This Pull Request bumps the Golang version to go1.21.10 and the bootstrap version to 18.9.

Do not trust the bot blindly. A thorough code review must be done to ensure all the files have been correctly modified.

There are a few manual steps remaining:

• Make sure you update the Golang version used in the previous and next release branches for the Upgrade/Downgrade tests.
• Build and Push the bootstrap images to Docker Hub, the bot cannot handle that.
• Update the ./.github/workflows/*.yml files with the newer Golang version, the bot cannot handle that due to permissions.
  • To accomplish this, run the following: go run ./go/tools/go-upgrade/go-upgrade.go upgrade workflows --go-to=1.21.10

cc @vitessio/release

[vitess-bot]

Hello! 👋

This Pull Request is now handled by arewefastyet. The current HEAD and future commits will be benchmarked.

You can find the performance comparison on the arewefastyet website.

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[frouioui]

Conditionally approving this, the changes look good but the bootstrap image has not been pushed yet as the base Golang image is not fully available yet, thus a couple of CI workflows will fail until I push the new bootstrap images.

~/vitess# docker pull golang:1.21.10-bullseye
1.21.10-bullseye: Pulling from library/golang
no matching manifest for linux/amd64 in the manifest list entries