Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schemadiff: more INSTANT DDL compliance #15871

Merged
merged 4 commits into from
May 8, 2024
Merged

schemadiff: more INSTANT DDL compliance #15871

merged 4 commits into from
May 8, 2024

Conversation

shlomi-noach
Copy link
Contributor

@shlomi-noach shlomi-noach commented May 8, 2024 •
edited by systay
Loading

Description

Continued schemadiff support for INSTANT DDL, we now fix the following two:

  • Adding a STORED virtual column is not instant-able
  • Adding columns such that the total number of columns exceeds 1022 is not instant-able. There's still a gap here because a statement might also remove columns at the same time. We opt right now to err on the safe side (reject an INSTANT where possibly it could be INSTANT-able rather than allowing an INSTANT when it would fail).

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@shlomi-noach
schemadiff: more INSTANT DDL compliance
1f88721 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach requested a review from a team May 8, 2024 05:40
@shlomi-noach shlomi-noach requested a review from deepthi as a code owner May 8, 2024 05:40
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented May 8, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels May 8, 2024
@shlomi-noach shlomi-noach changed the title schemadiff: more INSTANT DDL compliance schemadiff: more INSTANT DDL compliance May 8, 2024
@shlomi-noach shlomi-noach removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels May 8, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone May 8, 2024
@shlomi-noach
clarification
c392ae1 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
systay
systay reviewed May 8, 2024
View reviewed changes
go/vt/schemadiff/capability.go Outdated
@@ -110,13 +113,31 @@ func alterOptionCapableOfInstantDDL(alterOption sqlparser.AlterOption, createTab
if tableIsCompressed {
return false, nil
}
if len(createTable.TableSpec.Columns)+len(opt.Columns) > maxColumnsForInstantAddColumn {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicking: no tests found

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good nit! Added unit test and fixed the logic (because obviously there was a bug).

@shlomi-noach
fix logic, add unit test
3dece8c 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Adapt test
6b40bab 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach merged commit 04eb07f into vitessio:main May 8, 2024
91 checks passed
@shlomi-noach shlomi-noach deleted the schemadiff-instant-virtual branch May 8, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@systay systay systay approved these changes

@deepthi deepthi Awaiting requested review from deepthi

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Bug
Projects
None yet
Milestone
v20.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@shlomi-noach @systay @GuptaManan100