mysql: Handle more deprecated SQL commands

[dbussink]

This deals with more deprecated SQL commands that now uses different terminology on newer MySQL versions.

Also refactors things to reduce some duplication and to simplify some logic. We now treat the latest syntax as default and keep older syntax for older versions as needed explicitly.

Related Issue(s)

Part of #9515

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[codecov]

Codecov Report

Attention: Patch coverage is 17.41573% with 147 lines in your changes are missing coverage. Please review.

Project coverage is 68.42%. Comparing base (cbf89bd) to head (6d7b1dc).
Report is 10 commits behind head on main.

Files	Patch %	Lines
go/mysql/flavor_mysql_legacy.go	0.00%	116 Missing ⚠️
go/mysql/flavor_mysql.go	60.46%	17 Missing ⚠️
go/mysql/flavor_mariadb.go	0.00%	3 Missing ⚠️
go/vt/mysqlctl/backup.go	0.00%	3 Missing ⚠️
go/mysql/flavor_filepos.go	0.00%	2 Missing ⚠️
go/mysql/replication.go	0.00%	2 Missing ⚠️
go/vt/mysqlctl/fakemysqldaemon.go	0.00%	2 Missing ⚠️
go/mysql/flavor.go	80.00%	1 Missing ⚠️
go/vt/binlog/binlog_connection.go	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #15907      +/-   ##
==========================================
- Coverage   68.43%   68.42%   -0.02%     
==========================================
  Files        1559     1560       +1     
  Lines      196753   196920     +167     
==========================================
+ Hits       134657   134742      +85     
- Misses      62096    62178      +82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[harshit-gangal]

are these two commands removed?

[dbussink]

@harshit-gangal No, they are not, but they moved. It's how the fake tester works, it handles things in different ways for if they are called as single statements or with a list, which is annoying here but I didn't want to untangle that issue. We still run these commands.

You can see them being added here for example:

https://github.com/vitessio/vitess/pull/15907/files#diff-4a6888c5d16d73171003445c6d3226ae39bc38d5eb43d638234b13fe03b14f1cR238-R239