Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SchemaEngine: Ensure GetTableForPos returns table schema for "current" position by default #15912

Merged
merged 9 commits into from
May 20, 2024
Merged

SchemaEngine: Ensure GetTableForPos returns table schema for "current" position by default #15912

merged 9 commits into from
May 20, 2024

Commits on May 10, 2024

  1. SchemaEngine: GetTableForPos return latest schema when none found for… 

    … a position

This would typically mean that the historian is disabled, so we should return
the "current" schema at that time. This means that we need to reload
our cache before we return the current table schema.

Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 10, 2024
    Configuration menu
    Copy the full SHA
    7332061 View commit details
    Browse the repository at this point in the history

  2. Only reload when table is not in cache 

    Fixup tests

Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 10, 2024
    Configuration menu
    Copy the full SHA
    7414217 View commit details
    Browse the repository at this point in the history

  3. Improve func and remove FIXME 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 10, 2024
    Configuration menu
    Copy the full SHA
    8655975 View commit details
    Browse the repository at this point in the history

  4. Improve function and eliminate now unnecessary reloads 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 10, 2024
    Configuration menu
    Copy the full SHA
    cd3d27e View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/main' into vrepl_onlineddl_schema 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 10, 2024
    Configuration menu
    Copy the full SHA
    858c0ad View commit details
    Browse the repository at this point in the history

  6. More test fixes 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 10, 2024
    Configuration menu
    Copy the full SHA
    52438dd View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Add dedicated unit test 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 13, 2024
    Configuration menu
    Copy the full SHA
    194b84c View commit details
    Browse the repository at this point in the history

  2. Correct PK handling 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 13, 2024
    Configuration menu
    Copy the full SHA
    efd373f View commit details
    Browse the repository at this point in the history

  3. Minor changes after self review 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 13, 2024
    Configuration menu
    Copy the full SHA
    8282f55 View commit details
    Browse the repository at this point in the history