Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topo: Add version support to GetTopologyPath #15933

Merged
merged 17 commits into from
May 31, 2024

Correct comments

359a25c
Select commit
Loading
Failed to load commit list.
Merged

Topo: Add version support to GetTopologyPath #15933

Correct comments
359a25c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 22, 2024 in 0s

68.23% (-0.22%) compared to 9911880

View this Pull Request on Codecov

68.23% (-0.22%) compared to 9911880

Details

Codecov Report

Attention: Patch coverage is 39.18919% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 68.23%. Comparing base (9911880) to head (359a25c).
Report is 12 commits behind head on main.

Files Patch % Lines
go/cmd/vtctldclient/command/topology.go 18.18% 9 Missing ⚠️
go/vt/topo/stats_conn.go 0.00% 9 Missing ⚠️
go/vt/topo/etcd2topo/file.go 0.00% 8 Missing ⚠️
go/vt/vtctl/grpcvtctldserver/server.go 75.86% 7 Missing ⚠️
go/vt/topo/decode.go 50.00% 4 Missing ⚠️
go/vt/topo/consultopo/file.go 0.00% 2 Missing ⚠️
go/vt/topo/faketopo/faketopo.go 0.00% 2 Missing ⚠️
go/vt/topo/memorytopo/file.go 33.33% 2 Missing ⚠️
go/vt/topo/zk2topo/file.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15933      +/-   ##
==========================================
- Coverage   68.45%   68.23%   -0.22%     
==========================================
  Files        1562     1562              
  Lines      197057   197221     +164     
==========================================
- Hits       134891   134573     -318     
- Misses      62166    62648     +482     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.