Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VReplication: Improve workflow cancel/delete #15977

Merged
merged 37 commits into from
Jun 12, 2024
Merged

VReplication: Improve workflow cancel/delete #15977

merged 37 commits into from
Jun 12, 2024

Commits on May 20, 2024

  1. Workflow Delete: remove workflow before artifacts 

    Otherwise the cancel/delete and cleanup work can fail.

Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 20, 2024
    Configuration menu
    Copy the full SHA
    0b12d82 View commit details
    Browse the repository at this point in the history

  2. Add unit test 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 20, 2024
    Configuration menu
    Copy the full SHA
    4401a21 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Add timeouts to vx.CallbackContext usage 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 21, 2024
    Configuration menu
    Copy the full SHA
    51b75c1 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Don't fail workflow cancel/cleanup if there's nothing to do 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 22, 2024
    Configuration menu
    Copy the full SHA
    82005fb View commit details
    Browse the repository at this point in the history

  2. Improve and unify logging for tablet reference 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 22, 2024
    Configuration menu
    Copy the full SHA
    7dd69c2 View commit details
    Browse the repository at this point in the history

  3. Put initial denied tables entries in place on MoveTables create 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 22, 2024
    Configuration menu
    Copy the full SHA
    371c90c View commit details
    Browse the repository at this point in the history

  4. Get target keyspace lock before adding denied tables entries 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 22, 2024
    Configuration menu
    Copy the full SHA
    7b87e59 View commit details
    Browse the repository at this point in the history

  5. Comment out broken unit test for now 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 22, 2024
    Configuration menu
    Copy the full SHA
    8650d95 View commit details
    Browse the repository at this point in the history

  6. Adjust e2e tests 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 22, 2024
    Configuration menu
    Copy the full SHA
    4b381f5 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/main' into vtctldclient_wf_delete 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 22, 2024
    Configuration menu
    Copy the full SHA
    6fa20cf View commit details
    Browse the repository at this point in the history

  8. Adjust test after merging origin/main 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 22, 2024
    Configuration menu
    Copy the full SHA
    9fe930f View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Get vrepl e2e tests working 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 23, 2024
    Configuration menu
    Copy the full SHA
    4ea4dbe View commit details
    Browse the repository at this point in the history

  2. Fix backup tests 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 23, 2024
    Configuration menu
    Copy the full SHA
    dddf1c2 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Correct updatePrimaryTabletControl and test 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 29, 2024
    Configuration menu
    Copy the full SHA
    3758430 View commit details
    Browse the repository at this point in the history

  2. Complete/Cancel fixups 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 29, 2024
    Configuration menu
    Copy the full SHA
    0c6e12a View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Uncomment test 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 30, 2024
    Configuration menu
    Copy the full SHA
    862bdba View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Unify denied table rules management when doing traffic switches 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    5b4c288 View commit details
    Browse the repository at this point in the history

  2. Add unit test framework and test cases (scaffolding) 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    e501711 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into vtctldclient_wf_delete 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    5750a3c View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Ongoing improvements 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    e5f8acd View commit details
    Browse the repository at this point in the history

  2. Add scaffolding for MoveTables traffic switching unit test 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    c80f8a3 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Finish up new unit tests 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    4cf58c6 View commit details
    Browse the repository at this point in the history

  2. Move basic test to vtctldclient for static client uses 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    0a945ef View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into vtctldclient_wf_delete 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    2004173 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Changes from self review 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    aa572b8 View commit details
    Browse the repository at this point in the history

  2. Correct warning message 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    0c8a9ab View commit details
    Browse the repository at this point in the history

  3. Sort all the things in dry run switcher 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    1955b9a View commit details
    Browse the repository at this point in the history

  4. Add Traffic Switching DryRun unit test 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    392c8f6 View commit details
    Browse the repository at this point in the history

  5. Improve dry run unit test 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    0550ea0 View commit details
    Browse the repository at this point in the history

  6. Dry run unit test improvements part II 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    f86792c View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2024

  1. Be consistent with test framework mutex 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    46e8b1f View commit details
    Browse the repository at this point in the history

  2. Use std parameter name 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    ae34e94 View commit details
    Browse the repository at this point in the history

  3. Remove extraneous changes 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    b308ed7 View commit details
    Browse the repository at this point in the history

  4. Correct log message 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    93613ac View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2024

  1. Add routing rules helper to test framework 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    f66d6c2 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Trim down PR 

    These changes did not end up being necessary.

Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    4fc0037 View commit details
    Browse the repository at this point in the history

  2. Correct comment 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    904ba09 View commit details
    Browse the repository at this point in the history