Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update vitess-mixin go deps #15978

Closed
wants to merge 1 commit into from

Conversation

systay
Copy link
Collaborator

@systay systay commented May 20, 2024

Description

We recently updated the go config of the vitess-mixin project. After that was done, our IDEs started wanting to update and clean up the go.mod file, which is a bit annoying since we are not working on this project.

This PR updates the go.mod to the latest go version and the latest Vitess version. Hopefully this stops the auto-update from happening.

Related Issue(s)

#15918

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Signed-off-by: Andres Taylor <andres@planetscale.com>
Copy link
Contributor

vitess-bot bot commented May 20, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels May 20, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone May 20, 2024
@systay systay added Component: General Changes throughout the code base Type: Internal Cleanup Do Not Merge and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels May 20, 2024
@systay
Copy link
Collaborator Author

systay commented May 20, 2024

Let's hold off on merging until @frouioui and/or @deepthi has had a chance to review

@frouioui
Copy link
Member

It seems to be a duplicate of #15972. 15972 also updates the go upgrade tool to avoid this type of issue in the future.

@systay systay closed this May 20, 2024
@systay systay deleted the mixin-gomod branch May 20, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants