add support for vtgate traffic mirroring (queryserving) #15992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Englander <max@planetscale.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
maxenglander
added
Type: Feature
Component: Query Serving
and removed
NeedsDescriptionUpdate
5 tasks
Signed-off-by: Max Englander <max@planetscale.com>
Signed-off-by: Max Englander <max@planetscale.com>
Signed-off-by: Max Englander <max@planetscale.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15992 +/- ##
==========================================
+ Coverage 68.87% 68.88% +0.01%
==========================================
Files 1562 1564 +2
Lines 200624 201012 +388
==========================================
+ Hits 138179 138470 +291
- Misses 62445 62542 +97 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com> Signed-off-by: Max Englander <max.englander@gmail.com>
Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com> Signed-off-by: Max Englander <max.englander@gmail.com>
Signed-off-by: Max Englander <max@planetscale.com>
maxenglander
force-pushed
the
maxeng-mirror-routingrules-queryserving
branch
from
083c9e1
to
9ed0b03
Compare
Signed-off-by: Max Englander <max@planetscale.com>
Signed-off-by: Max Englander <max@planetscale.com>
maxenglander
force-pushed
the
maxeng-mirror-routingrules-queryserving
branch
from
9ed0b03
to
2a786e5
Compare
Signed-off-by: Max Englander <max@planetscale.com>
Comment on lines
186
to
187
| // ErrNotSingleTable refers to an error happening when something should be used only for single tables | ||
| var ErrNotSingleTable = vterrors.Errorf(vtrpcpb.Code_INTERNAL, "[BUG] should only be used for single tables") |
There was a problem hiding this comment.
nit: could use vterrors.VT13001
Comment on lines
1020
to
1026
| mi := MirrorInfo{} | ||
| for _, t := range tableInfos { | ||
| if mr := t.GetMirrorRule(); mr != nil { | ||
| if mi.Percent == 0 || mr.Percent < mi.Percent { | ||
| mi.Percent = mr.Percent | ||
| } | ||
| } |
There was a problem hiding this comment.
we can specifically check for RealTable type here and check on the mirror rule.
There was a problem hiding this comment.
are you saying we can remove the GetMirrorRule method from TableInfo and just directly check for t.(*RealTable)?
There was a problem hiding this comment.
yes, we can type cast it and check the mirror rule
Comment on lines
46
to
65
| cloneMirror := *m | ||
| cloneMirror.Percent = m.Percent | ||
| cloneMirror.Operator = inputs[0] | ||
| cloneMirror.Target = inputs[1] | ||
| return &cloneMirror | ||
| } | ||
|
|
||
| // Inputs returns the inputs for this operator | ||
| func (m *PercentBasedMirror) Inputs() []Operator { | ||
| return []Operator{ | ||
| m.Operator, | ||
| m.Target, | ||
| } | ||
| } | ||
|
|
||
| // SetInputs changes the inputs for this op | ||
| func (m *PercentBasedMirror) SetInputs(inputs []Operator) { | ||
| m.Operator = inputs[0] | ||
| m.Target = inputs[1] | ||
| } |
There was a problem hiding this comment.
nit: better to check the slice length before using indices.
Comment on lines
72
to
77
| panic("not supported") | ||
| } | ||
|
|
||
| func (m *PercentBasedMirror) AddColumn(ctx *plancontext.PlanningContext, reuseExisting bool, addToGroupBy bool, expr *sqlparser.AliasedExpr) int { | ||
| panic("not supported") | ||
| } |
There was a problem hiding this comment.
nit: for all the panic send along and error inside, like panic(vterrors.VT13001(...))
Comment on lines
5
to
20
| "from_table": "unsharded_src1.t1", | ||
| "to_table": "unsharded_dst1.t1", | ||
| "percent": 50 | ||
| }, | ||
| { | ||
| "from_table": "unsharded_src1.t2", | ||
| "to_table": "sharded_dst1.t1", | ||
| "percent": 50 | ||
| }, | ||
| { | ||
| "from_table": "unsharded_src2.t1", | ||
| "to_table": "unsharded_src2.t1", | ||
| "percent": 50 | ||
| }, | ||
| { | ||
| "from_table": "unsharded_src2.t2", |
There was a problem hiding this comment.
having variable percentage would be a good to have, also to verify which percentage the plan selects
…s, return mirror keyspace Signed-off-by: Max Englander <max@planetscale.com>
… case Signed-off-by: Max Englander <max@planetscale.com>
Signed-off-by: Max Englander <max@planetscale.com>
Signed-off-by: Max Englander <max@planetscale.com>
Signed-off-by: Max Englander <max@planetscale.com>
Signed-off-by: Max Englander <max@planetscale.com>
Co-authored-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Max Englander <max.englander@gmail.com>
Signed-off-by: Max Englander <max@planetscale.com>
harshit-gangal
approved these changes
Aug 23, 2024
|
Not sure why DCO check is still pending. I assume all the commits are correctly signed off. @maxenglander if you can confirm that, we can bypass and merge instead of a force-push -> Run CI all over again -> merge. |
|
Hey @deepthi all the commits have the "Verified" sign on GH, and each commit individually has the |
venkatraju
pushed a commit
to slackhq/vitess
that referenced
this pull request
Aug 29, 2024
Signed-off-by: Max Englander <max@planetscale.com> Signed-off-by: Max Englander <max.englander@gmail.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com> Co-authored-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Query-serving component for #15945.
Related Issue(s)
#13772
#15945
Checklist
Deployment Notes