Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tablet throttler: recent check diff fix #16001

Merged
merged 2 commits into from
May 31, 2024
Merged

Tablet throttler: recent check diff fix #16001

merged 2 commits into from
May 31, 2024

Conversation

shlomi-noach
Copy link
Contributor

@shlomi-noach shlomi-noach commented May 23, 2024 •
edited by mattlord
Loading

Description

Followup to #15397 and #15398

When the Primary throttler probes a replica throttler, the replica's CheckResult includes a RecentlyChecked boolean field.
That field was not set correctly, and was false in almost all internal vitess probing situations. The stimulation introduced in #15398 thankfully prevents a complete starvation of the throttler. However, with RecentlyChecked reported as false more than it should, the Primary will not renew the heartbeat lease as much as it should, leading to more throttling scenarios.

In this PR we ensure to return a RecentlyChecked = true value when the throttler has, in fact, been recently checked in the past second-or-so, by any other check.

Related Issue(s)

#15397

Found while working/testing #15988

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

@shlomi-noach
Tablet throttler: recent check diff fix
6456fcf 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
test recent check period
d45ff81 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented May 23, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels May 23, 2024
@shlomi-noach shlomi-noach requested a review from a team May 23, 2024 05:32
@github-actions github-actions bot added this to the v20.0.0 milestone May 23, 2024
@shlomi-noach shlomi-noach added Type: Bug Component: Throttler and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels May 23, 2024
@codecov Codecov
Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 52.94118% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 68.26%. Comparing base (a1edaee) to head (d45ff81).
Report is 1 commits behind head on main.

Files Patch % Lines
go/vt/vttablet/tabletserver/throttle/throttler.go 52.94% 8 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16001      +/-   ##
==========================================
+ Coverage   68.24%   68.26%   +0.01%     
==========================================
  Files        1562     1562              
  Lines      197171   197185      +14     
==========================================
+ Hits       134550   134599      +49     
+ Misses      62621    62586      -35

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mattlord
mattlord approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ❤️

go/vt/vttablet/tabletserver/throttle/throttler_test.go
{
checkResult := throttler.CheckByType(ctx, throttlerapp.VitessName.String(), "", flags, ThrottleCheckSelf)
assert.False(t, checkResult.RecentlyChecked) // "vitess" app does not mark the throttler as recently checked
assert.False(t, throttler.recentlyChecked()) // "vitess" app does not mark the throttler as recently checked
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one isn't by app name, is it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not this one. This is a general purpose "has anyone been bothering this throttler"

@shlomi-noach shlomi-noach requested a review from a team May 27, 2024 10:41
@shlomi-noach shlomi-noach mentioned this pull request May 30, 2024
Closed
49 tasks
@deepthi deepthi merged commit bec711b into vitessio:main May 31, 2024
101 of 105 checks passed
@deepthi deepthi deleted the throttler-recently-checked-fix branch May 31, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattlord mattlord mattlord approved these changes

@deepthi deepthi deepthi approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

Assignees
No one assigned
Labels
Component: Throttler Type: Bug
Projects
None yet
Milestone
v20.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@shlomi-noach @deepthi @mattlord