Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetServerStatus RPC to use in PRS #16022

Merged
merged 4 commits into from
Jun 3, 2024
Merged

Conversation

GuptaManan100
Copy link
Member

Description

This PR starts the work for #15946.
In order to use the replica which has the innodb buffer pool loaded the most, we first need the ability to read that said value. This PR adds a new RPC to the tablet manager client interface for this.

In the next release, when this RPC is available on all the vttablets, we can use this RPC instead of PrimaryStatus to check for the availability of all the replicas in PRS. Currently we are throwing away the results of PrimaryStatus. Instead we can call GetServerStatus and even use the results for better choosing the primary candidate.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Manan Gupta <manan@planetscale.com>
Copy link
Contributor

vitess-bot bot commented May 29, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels May 29, 2024
@GuptaManan100 GuptaManan100 removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels May 29, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone May 29, 2024
@GuptaManan100 GuptaManan100 mentioned this pull request May 29, 2024
5 tasks
Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 42.25352% with 41 lines in your changes missing coverage. Please review.

Project coverage is 68.21%. Comparing base (0c2856e) to head (347d413).
Report is 15 commits behind head on main.

Current head 347d413 differs from pull request most recent head d2d88bf

Please upload reports for the commit d2d88bf to get more accurate results.

Files Patch % Lines
go/vt/mysqlctl/replication.go 0.00% 20 Missing ⚠️
...t/vtctl/grpcvtctldserver/testutil/test_tmclient.go 0.00% 7 Missing ⚠️
go/vt/vtcombo/tablet_map.go 0.00% 5 Missing ⚠️
go/vt/mysqlctl/fakemysqldaemon.go 0.00% 4 Missing ⚠️
go/vt/vttablet/faketmclient/fake_client.go 0.00% 2 Missing ⚠️
go/vt/vttablet/tabletmanager/rpc_actions.go 0.00% 2 Missing ⚠️
go/vt/vttablet/grpctmclient/client.go 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16022      +/-   ##
==========================================
- Coverage   68.24%   68.21%   -0.04%     
==========================================
  Files        1541     1541              
  Lines      197117   197305     +188     
==========================================
+ Hits       134530   134595      +65     
- Misses      62587    62710     +123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuptaManan100 GuptaManan100 mentioned this pull request May 31, 2024
49 tasks
go/vt/mysqlctl/replication.go Outdated Show resolved Hide resolved
go/vt/mysqlctl/replication.go Outdated Show resolved Hide resolved
go/test/endtoend/tabletmanager/tablet_test.go Outdated Show resolved Hide resolved
go/test/endtoend/tabletmanager/tablet_test.go Outdated Show resolved Hide resolved
go/vt/mysqlctl/mysql_daemon.go Outdated Show resolved Hide resolved
go/vt/mysqlctl/replication.go Outdated Show resolved Hide resolved
go/test/endtoend/tabletmanager/tablet_test.go Outdated Show resolved Hide resolved
proto/tabletmanagerdata.proto Outdated Show resolved Hide resolved
Signed-off-by: Manan Gupta <manan@planetscale.com>
Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @GuptaManan100 ! I only had some nits and you can address those are you feel is best.

go/vt/mysqlctl/fakemysqldaemon.go Outdated Show resolved Hide resolved
go/vt/mysqlctl/replication.go Outdated Show resolved Hide resolved
return nil, err
}
}
qr, err := mysqld.FetchSuperQuery(ctx, query)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it's worth creating a mysqld.FetchQuery helper (doesn't have to be done here) as there should be no need to use the DBA pool for this and various other things.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do that change as a follow up. Currently rushing to get this into RC

go/vt/mysqlctl/replication.go Outdated Show resolved Hide resolved
go/vt/mysqlctl/replication.go Outdated Show resolved Hide resolved
go/vt/vtcombo/tablet_map.go Outdated Show resolved Hide resolved
go/test/endtoend/tabletmanager/main_test.go Outdated Show resolved Hide resolved
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments from @mattlord seem worth addressing. Rest LGTM.

proto/tabletmanagerdata.proto Outdated Show resolved Hide resolved
go/test/endtoend/tabletmanager/main_test.go Outdated Show resolved Hide resolved
@deepthi
Copy link
Member

deepthi commented Jun 3, 2024

Leaving this to @GuptaManan100 to merge once remaining feedback has been addressed.

Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
@deepthi
Copy link
Member

deepthi commented Jun 3, 2024

DCO seems to be stuck everywhere. I've manually verified that all commits have the necessary signoff. Bypassing that check to merge.

@deepthi deepthi merged commit d48ef18 into vitessio:main Jun 3, 2024
93 of 94 checks passed
@deepthi deepthi deleted the server-status branch June 3, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Cluster management Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants