Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: order by subquery planning #16049

Merged
merged 16 commits into from
Jun 12, 2024
Merged

fix: order by subquery planning #16049

merged 16 commits into from
Jun 12, 2024

Commits on Jun 11, 2024

  1. feat: rewrite subquery columns while they are pushed down 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    3b2ace3 View commit details
    Browse the repository at this point in the history

  2. feat: make sure to check column name alignment with size checks first 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    b8a366a View commit details
    Browse the repository at this point in the history

  3. refactor: rename IsProjection to IsArgument for understandability 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    1a52f18 View commit details
    Browse the repository at this point in the history

  4. feat: allow empty expressions 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    bd81e8a View commit details
    Browse the repository at this point in the history

  5. feat: optimize subqueries used in both select and order by 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    962ec6c View commit details
    Browse the repository at this point in the history

  6. feat: rewrite subqueries that have been merged and are used in ordering 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    94b2aab View commit details
    Browse the repository at this point in the history

  7. extract aggregation function arguments for subquery handling 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal @systay
    harshit-gangal authored and systay committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    e9d6658 View commit details
    Browse the repository at this point in the history

  8. only change original if we have no AggrFunc 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    9fc74e4 View commit details
    Browse the repository at this point in the history

  9. clone on the way down, and replace on the way up 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    1c47ee3 View commit details
    Browse the repository at this point in the history

  10. clean up. refactor and comment 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    7bce87c View commit details
    Browse the repository at this point in the history

  11. compact subqueries earlier 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    63d02d4 View commit details
    Browse the repository at this point in the history

  12. remove unused code 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    3f7b825 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. chore: refactor and some additional comments and renames 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    973f29f View commit details
    Browse the repository at this point in the history

  2. refactor: move methods 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    9b9f1b3 View commit details
    Browse the repository at this point in the history

  3. test: add end to end tests 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    608755d View commit details
    Browse the repository at this point in the history

  4. Skip TestSubqueries if vtgate < 21 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    37ec476 View commit details
    Browse the repository at this point in the history