-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v20 backport: CI upgrade/downgrade tests for Online DDL / throttler / vreplication flow #16065
Merged
shlomi-noach
merged 2 commits into
vitessio:release-20.0
from
planetscale:ci-upgrade-downgrade-onlineddl-20.0
Jun 10, 2024
Merged
v20 backport: CI upgrade/downgrade tests for Online DDL / throttler / vreplication flow #16065
shlomi-noach
merged 2 commits into
vitessio:release-20.0
from
planetscale:ci-upgrade-downgrade-onlineddl-20.0
Jun 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flow (vitessio#16017) Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
shlomi-noach
added
Component: VReplication
Type: Testing
Backport
This is a backport
Component: Online DDL
Online DDL (vitess/native/gh-ost/pt-osc)
Component: Throttler
Backport to: release-20.0-rc
labels
Jun 5, 2024
shlomi-noach
requested review from
GuptaManan100,
frouioui,
rohit-nayak-ps,
deepthi,
mattlord and
harshit-gangal
as code owners
June 5, 2024 04:12
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-20.0 #16065 +/- ##
================================================
+ Coverage 68.20% 68.22% +0.02%
================================================
Files 1541 1541
Lines 197330 197330
================================================
+ Hits 134591 134635 +44
+ Misses 62739 62695 -44 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
rohit-nayak-ps
approved these changes
Jun 9, 2024
mattlord
approved these changes
Jun 9, 2024
vitess-bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
… vreplication flow (#16065) Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
shlomi-noach
added a commit
that referenced
this pull request
Jun 10, 2024
… DDL / throttler / vreplication flow (#16065) (#16082) Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com> Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport
This is a backport
Component: Online DDL
Online DDL (vitess/native/gh-ost/pt-osc)
Component: Throttler
Component: VReplication
Type: Testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the backport of #16017
Backporting manually as I forgot to add the backport label.
Description
Adding upgrade/downgrade tests as follows:
X
version VTTablet primary, withY
VTTablet replica. See breakdown below.vitess
strategy, thereby running VReplication that is also using the throttler.See more details in https://github.com/vitessio/vitess/pull/16017/files#diff-dc6e3889488266071984d6da1f44795b7b06bf5ff6504c8e9aa359598918230aR17-R37
This will test cross version compatibility of the throttler, of vreplication, of Online DDL. It runs
onlineddl_flow
in the following setups:Each such flow runs at about 1 minute, which is why I chose to aggregate them all in the same workflow test (as opposed to splitting to "new" and "old")
EDIT: sample execution flow: https://github.com/vitessio/vitess/actions/runs/9348746367/job/25728525330?pr=16017
Related Issue(s)
No specific issue, but with #15988 in mind.
Checklist
Deployment Notes