Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Online DDL: Fail a --in-order-completion migration, if a _prior_ migration within the same context is 'failed' or 'cancelled' #16071

Merged
merged 9 commits into from
Jun 6, 2024
Merged

Online DDL: Fail a --in-order-completion migration, if a _prior_ migration within the same context is 'failed' or 'cancelled' #16071

merged 9 commits into from
Jun 6, 2024

Commits on May 2, 2024

  1. refactor getNonConflictingMigration function 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed May 2, 2024
    Configuration menu
    Copy the full SHA
    a5f2c54 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. early break 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed May 6, 2024
    Configuration menu
    Copy the full SHA
    768d426 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Merge branch 'main' into onlineddl-in-order-execution 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    f621067 View commit details
    Browse the repository at this point in the history

  2. Adding scheduler tests for sequential in-order completion, expect ear… 

    …ly bail out when one migration fails. This last test will fail and a followup commit will implement the code

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    e73ce7a View commit details
    Browse the repository at this point in the history

  3. add query to select migrations by context 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    a24634e View commit details
    Browse the repository at this point in the history

  4. Test that a runniing in-order migration fails if a prior migration is… 

    … cancelled/failed

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    d2eff24 View commit details
    Browse the repository at this point in the history

  5. all in one 'sqlSelectFailedCancelledMigrationsInContextBeforeMigratio… 

    …n' query picks a failed or cancelled migration with a given migration context, and which comes before a given migration

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    7d6cee0 View commit details
    Browse the repository at this point in the history

  6. Fail a --in-order-completion migration, if a _prior_ migration within… 

    … the same context is 'failed' or 'cancelled'. Failing happens either at 'ready' state or at 'running' state

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    1cf18be View commit details
    Browse the repository at this point in the history

  7. use assert.Len, require.Len 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    c429499 View commit details
    Browse the repository at this point in the history