Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: cleaner cloning API #16079

Merged
merged 3 commits into from
Jun 10, 2024

fix: only clone types that implement SQLNode

9d78ad3
Select commit
Loading
Failed to load commit list.
Merged

refactor: cleaner cloning API #16079

fix: only clone types that implement SQLNode
9d78ad3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 10, 2024 in 0s

68.22% (+0.02%) compared to 87ecae7

View this Pull Request on Codecov

68.22% (+0.02%) compared to 87ecae7

Details

Codecov Report

Attention: Patch coverage is 88.40580% with 8 lines in your changes missing coverage. Please review.

Project coverage is 68.22%. Comparing base (87ecae7) to head (9d78ad3).

Files Patch % Lines
go/vt/vtgate/simplifier/simplifier.go 71.42% 4 Missing ⚠️
go/vt/vttablet/onlineddl/executor.go 33.33% 2 Missing ⚠️
go/vt/vtgate/planbuilder/operators/table.go 0.00% 1 Missing ⚠️
go/vt/vtgate/vschema_manager.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16079      +/-   ##
==========================================
+ Coverage   68.19%   68.22%   +0.02%     
==========================================
  Files        1541     1541              
  Lines      197369   197371       +2     
==========================================
+ Hits       134605   134650      +45     
+ Misses      62764    62721      -43

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov