Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-20.0] fix: order by subquery planning (#16049) #16134

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

vitess-bot[bot]
Copy link
Contributor

@vitess-bot vitess-bot bot commented Jun 12, 2024

Description

This is a backport of #16049

Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot vitess-bot bot added the Backport This is a backport label Jun 12, 2024
@vitess-bot vitess-bot bot requested a review from systay as a code owner June 12, 2024 15:33
@vitess-bot vitess-bot bot added Component: Query Serving Release Blocker: release-20.0 This item blocks the release on branch release-20.0 labels Jun 12, 2024
@vitess-bot vitess-bot bot requested a review from frouioui as a code owner June 12, 2024 15:33
@vitess-bot vitess-bot bot added the Type: Bug label Jun 12, 2024
@vitess-bot vitess-bot bot requested a review from GuptaManan100 as a code owner June 12, 2024 15:33
Copy link
Contributor Author

vitess-bot bot commented Jun 12, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v20.0.0 milestone Jun 12, 2024
@frouioui frouioui removed the Release Blocker: release-20.0 This item blocks the release on branch release-20.0 label Jun 12, 2024
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 60.76555% with 82 lines in your changes missing coverage. Please review.

Project coverage is 68.44%. Comparing base (f683028) to head (b6645ce).
Report is 2 commits behind head on release-20.0.

Files Patch % Lines
go/vt/sqlparser/ast.go 5.00% 38 Missing ⚠️
.../vt/vtgate/planbuilder/operators/query_planning.go 58.97% 16 Missing ⚠️
go/vt/vtgate/planbuilder/operators/subquery.go 33.33% 10 Missing ⚠️
go/vt/vtgate/planbuilder/operators/aggregator.go 80.00% 5 Missing ⚠️
go/vt/vtgate/planbuilder/operators/projection.go 71.42% 4 Missing ⚠️
.../vtgate/planbuilder/operators/subquery_planning.go 80.95% 4 Missing ⚠️
.../vtgate/planbuilder/operators/horizon_expanding.go 88.46% 3 Missing ⚠️
go/vt/sqlparser/ast_funcs.go 80.00% 1 Missing ⚠️
...vtgate/planbuilder/operators/subquery_container.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-20.0   #16134      +/-   ##
================================================
+ Coverage         68.20%   68.44%   +0.24%     
================================================
  Files              1541     1541              
  Lines            197339   198908    +1569     
================================================
+ Hits             134601   136150    +1549     
- Misses            62738    62758      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frouioui frouioui merged commit d50d290 into release-20.0 Jun 12, 2024
183 checks passed
@frouioui frouioui deleted the backport-16049-to-release-20.0 branch June 12, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant