-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-20.0-rc] refactor: cleaner cloning API (#16079) #16136
[release-20.0-rc] refactor: cleaner cloning API (#16079) #16136
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com>
ffa23f1
to
2c3d503
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-20.0-rc #16136 +/- ##
===================================================
+ Coverage 68.24% 68.50% +0.25%
===================================================
Files 1541 1541
Lines 197330 197472 +142
===================================================
+ Hits 134665 135273 +608
+ Misses 62665 62199 -466 ☔ View full report in Codecov by Sentry. |
Although the refactor does not seem risky, let's not backport this to 20.0. It is also not needed for the subquery fix #16049 on release branches. |
Description
Backport of #16079
Needed to backport the Regression fix #16049
Related Issue(s)
Checklist
Deployment Notes