Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding new mysql shell backup engine #16295

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
+1,447 −128

Merge branch 'backup-pitr-replication' into mysqlshell-backup

1fa6191
Select commit
Loading
Failed to load commit list.
Open

adding new mysql shell backup engine #16295

Merge branch 'backup-pitr-replication' into mysqlshell-backup
1fa6191
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 19, 2024 in 0s

69.43% (-0.10%) compared to 56c39b2

View this Pull Request on Codecov

69.43% (-0.10%) compared to 56c39b2

Details

Codecov Report

Attention: Patch coverage is 25.30864% with 242 lines in your changes missing coverage. Please review.

Project coverage is 69.43%. Comparing base (56c39b2) to head (1fa6191).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/mysqlctl/mysqlshellbackupengine.go 24.37% 211 Missing ⚠️
go/vt/mysqlctl/query.go 0.00% 21 Missing ⚠️
go/vt/mysqlctl/fakemysqldaemon.go 33.33% 4 Missing ⚠️
go/vt/mysqlctl/backup.go 83.33% 2 Missing ⚠️
go/vt/mysqlctl/builtinbackupengine.go 0.00% 2 Missing ⚠️
go/vt/mysqlctl/xtrabackupengine.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16295      +/-   ##
==========================================
- Coverage   69.53%   69.43%   -0.10%     
==========================================
  Files        1567     1568       +1     
  Lines      202388   202714     +326     
==========================================
+ Hits       140723   140758      +35     
- Misses      61665    61956     +291

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov