Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/vt/sqlparser: improve performance in TrackedBuffer formatting #16364

Merged
merged 2 commits into from
Sep 16, 2024

Merge remote-tracking branch 'upstream/main' into tracker-buffer-perf

57b4035
Select commit
Loading
Failed to load commit list.
Merged

go/vt/sqlparser: improve performance in TrackedBuffer formatting #16364

Merge remote-tracking branch 'upstream/main' into tracker-buffer-perf
57b4035
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 16, 2024 in 0s

68.92% (+0.00%) compared to 6fc808d

View this Pull Request on Codecov

68.92% (+0.00%) compared to 6fc808d

Details

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.92%. Comparing base (6fc808d) to head (57b4035).

Files with missing lines Patch % Lines
go/vt/sqlparser/tracked_buffer.go 93.75% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16364   +/-   ##
=======================================
  Coverage   68.91%   68.92%           
=======================================
  Files        1566     1566           
  Lines      201855   201885   +30     
=======================================
+ Hits       139113   139147   +34     
+ Misses      62742    62738    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.