-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix panic in user defined aggregation functions planning #16398
Conversation
Signed-off-by: Manan Gupta <manan@planetscale.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16398 +/- ##
==========================================
- Coverage 68.68% 68.67% -0.01%
==========================================
Files 1548 1548
Lines 199063 199087 +24
==========================================
+ Hits 136721 136727 +6
- Misses 62342 62360 +18 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix!
Signed-off-by: Manan Gupta <manan@planetscale.com>
Description
This PR fixes the panic found in #16397.
On investigation it was found that this panic was introduced in the changes in #16049. This PR fixes the panic and also adds test cases to verify we are able to plan udf queries properly and fail in case we are unable to push them down to MySQL.
Related Issue(s)
Checklist
Deployment Notes