Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional recursive CTE work #16616

Merged
merged 6 commits into from
Aug 26, 2024
Merged

Additional recursive CTE work #16616

merged 6 commits into from
Aug 26, 2024

Conversation

systay
Copy link
Collaborator

@systay systay commented Aug 19, 2024

Description

Issues in this first implementation found and fixed in this PR. They include:

  • Correctly handle the case when we only use the CTE table in the RHS of the recursive UNION
  • Merging CTEs in more situations
  • Handle UNION DISTINCT in the CTE definition
  • Stop predicate push down

Related Issue(s)

Part of #16415

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Copy link
Contributor

vitess-bot bot commented Aug 19, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Aug 19, 2024
@systay systay changed the title handle merging with dual on the RHS of recursive UNION Additional recursive CTE work Aug 19, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Aug 19, 2024
@systay systay added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 68.57143% with 11 lines in your changes missing coverage. Please review.

Project coverage is 68.96%. Comparing base (538dd4c) to head (3fc86a4).
Report is 8 commits behind head on main.

Files Patch % Lines
go/vt/vtgate/planbuilder/operators/recurse_cte.go 64.28% 5 Missing ⚠️
go/vt/vtgate/planbuilder/operators/SQL_builder.go 55.55% 4 Missing ⚠️
go/vt/vtgate/planbuilder/operators/cte_merging.go 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16616      +/-   ##
==========================================
- Coverage   68.98%   68.96%   -0.02%     
==========================================
  Files        1562     1562              
  Lines      200690   200744      +54     
==========================================
+ Hits       138449   138451       +2     
- Misses      62241    62293      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment on lines 137 to 140
case nil:
sel := &sqlparser.Select{}
addPred = sel.AddWhere
qb.stmt = sel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment when the statement type be nil

Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay merged commit e6843dc into vitessio:main Aug 26, 2024
129 checks passed
@systay systay deleted the recursive-cte branch August 26, 2024 06:22
venkatraju pushed a commit to slackhq/vitess that referenced this pull request Aug 29, 2024
Signed-off-by: Andres Taylor <andres@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants