Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VDiff: Add control for start/resume and stop #16654

Merged
merged 25 commits into from
Sep 7, 2024

Add span annotations

9eabc9d
Select commit
Loading
Failed to load commit list.
Merged

VDiff: Add control for start/resume and stop #16654

Add span annotations
9eabc9d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 7, 2024 in 0s

68.94% (+0.01%) compared to 5ced946

View this Pull Request on Codecov

68.94% (+0.01%) compared to 5ced946

Details

Codecov Report

Attention: Patch coverage is 33.33333% with 66 lines in your changes missing coverage. Please review.

Project coverage is 68.94%. Comparing base (5ced946) to head (9eabc9d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vttablet/tabletmanager/vdiff/action.go 0.00% 47 Missing ⚠️
...d/vtctldclient/command/vreplication/vdiff/vdiff.go 45.45% 6 Missing ⚠️
.../vtctldclient/command/vreplication/common/utils.go 0.00% 5 Missing ⚠️
go/vt/vtctl/grpcvtctldserver/server.go 0.00% 3 Missing ⚠️
go/vt/vtctl/workflow/utils.go 82.35% 3 Missing ⚠️
go/vt/vtctl/workflow/server.go 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16654      +/-   ##
==========================================
+ Coverage   68.92%   68.94%   +0.01%     
==========================================
  Files        1565     1565              
  Lines      201682   201745      +63     
==========================================
+ Hits       139010   139090      +80     
+ Misses      62672    62655      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.