-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the vitess-mixin #16657
Remove the vitess-mixin #16657
Conversation
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The golang-upgrade tool must be updated too so it does not try to update vitess-mixin
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16657 +/- ##
==========================================
- Coverage 68.93% 68.92% -0.02%
==========================================
Files 1562 1562
Lines 200767 200767
==========================================
- Hits 138407 138378 -29
- Misses 62360 62389 +29 ☔ View full report in Codecov by Sentry. |
Done! |
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Description
Based on the discussion in #16613, this removes the
vitess-mixin
directory. It's currently not maintained, it causes issues with security alerts etc. and none of the currently active Vitess maintainers know how it works or use it.Related Issue(s)
#16613
Checklist