Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update micromatch to 4.0.8 #16660

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Update micromatch to 4.0.8 #16660

merged 1 commit into from
Aug 27, 2024

Conversation

frouioui
Copy link
Member

Description

This PR bumps our npm package micromatch from 4.0.5 to 4.0.8. This fixes a CVE https://github.com/vitessio/vitess/security/dependabot/385 that is fixed in 4.0.8.

@frouioui
Update micromatch to 4.0.8
230c6bf 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Aug 27, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Aug 27, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Aug 27, 2024
@frouioui frouioui added Component: VTAdmin VTadmin interface Type: CI/Build Backport to: release-18.0 Needs to be back ported to release-18.0 Backport to: release-19.0 Needs to be back ported to release-19.0 Backport to: release-20.0 Needs to be backport to release-20.0 and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Aug 27, 2024
@frouioui frouioui requested review from rohit-nayak-ps and a team August 27, 2024 18:02
@deepthi deepthi merged commit 0d4aa03 into vitessio:main Aug 27, 2024
141 of 145 checks passed
@deepthi deepthi deleted the bump-micromatch branch August 27, 2024 22:51
vitess-bot pushed a commit that referenced this pull request Aug 27, 2024
@vitess-bot @vitess-bot
Update micromatch to 4.0.8 (#16660)
2105b41 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot vitess-bot bot mentioned this pull request Aug 27, 2024
Merged
vitess-bot pushed a commit that referenced this pull request Aug 27, 2024
@vitess-bot @vitess-bot
Update micromatch to 4.0.8 (#16660)
d3c21d8 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot vitess-bot bot mentioned this pull request Aug 27, 2024
Merged
vitess-bot pushed a commit that referenced this pull request Aug 27, 2024
@vitess-bot @vitess-bot
Update micromatch to 4.0.8 (#16660)
d64b862 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot vitess-bot bot mentioned this pull request Aug 27, 2024
Merged
frouioui pushed a commit that referenced this pull request Aug 28, 2024
@vitess-bot
[release-18.0] Update micromatch to 4.0.8 (#16660) (#16665)
3ba8b8c 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
frouioui pushed a commit that referenced this pull request Aug 28, 2024
@vitess-bot
[release-20.0] Update micromatch to 4.0.8 (#16660) (#16667)
f0de782 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
frouioui pushed a commit that referenced this pull request Aug 28, 2024
@vitess-bot
[release-19.0] Update micromatch to 4.0.8 (#16660) (#16666)
cbe33ad 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
venkatraju pushed a commit to slackhq/vitess that referenced this pull request Aug 29, 2024
@frouioui @venkatraju
Update micromatch to 4.0.8 (vitessio#16660)
3130563 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@mattlord mattlord mattlord approved these changes

@ajm188 ajm188 Awaiting requested review from ajm188 ajm188 is a code owner

@notfelineit notfelineit Awaiting requested review from notfelineit notfelineit is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps

Assignees
No one assigned
Labels
Backport to: release-18.0 Needs to be back ported to release-18.0 Backport to: release-19.0 Needs to be back ported to release-19.0 Backport to: release-20.0 Needs to be backport to release-20.0 Component: VTAdmin VTadmin interface Type: CI/Build
Projects
None yet
Milestone
v21.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@frouioui @deepthi @mattlord