Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SidecarDB: Don't ignore table charset and collation #16670

Merged
merged 5 commits into from
Sep 8, 2024
Merged

SidecarDB: Don't ignore table charset and collation #16670

merged 5 commits into from
Sep 8, 2024

Commits on Aug 28, 2024

  1. Don't ignore table charset and collation 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    028b8b8 View commit details
    Browse the repository at this point in the history

  2. Add unit test 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    7f45f5a View commit details
    Browse the repository at this point in the history

  3. Remove unintentional change 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    403b474 View commit details
    Browse the repository at this point in the history

  4. Move all sidecar tables explicitly to utf8mb4 

    And then ignore charset/collation when either is empty

Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    ebad904 View commit details
    Browse the repository at this point in the history

  5. Add case to unit test 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    8fb0607 View commit details
    Browse the repository at this point in the history