Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-19.0] JSON Encoding: Use Type_RAW for marshalling json (#16637) #16681

Merged
merged 7 commits into from
Sep 4, 2024

Conversation

vitess-bot[bot]
Copy link
Contributor

@vitess-bot vitess-bot bot commented Aug 29, 2024

Description

This is a backport of #16637

Copy link
Contributor Author

vitess-bot bot commented Aug 29, 2024

Hello @rohit-nayak-ps, there are conflicts in this backport.

Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually.

Make sure you replace origin by the name of the vitessio/vitess remote

git fetch --all
gh pr checkout 16681 -R vitessio/vitess
git reset --hard origin/release-19.0
git cherry-pick -m 1 e89f684b09afbbe494db8d9394f7045a61d84e14

Copy link
Contributor Author

vitess-bot bot commented Aug 29, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot requested a review from deepthi August 29, 2024 09:59
@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request labels Aug 29, 2024
@vitess-bot vitess-bot bot requested a review from frouioui August 29, 2024 09:59
@vitess-bot vitess-bot bot added the NeedsWebsiteDocsUpdate What it says label Aug 29, 2024
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@github-actions github-actions bot added this to the v19.0.6 milestone Aug 29, 2024
@rohit-nayak-ps rohit-nayak-ps removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says Skip CI Skip CI actions from running NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required Merge Conflict labels Aug 29, 2024
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.39%. Comparing base (cbe33ad) to head (cff441d).
Report is 2 commits behind head on release-19.0.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-19.0   #16681      +/-   ##
================================================
+ Coverage         67.36%   67.39%   +0.03%     
================================================
  Files              1560     1560              
  Lines            193263   193263              
================================================
+ Hits             130183   130243      +60     
+ Misses            63080    63020      -60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps rohit-nayak-ps marked this pull request as ready for review September 4, 2024 10:40
@shlomi-noach shlomi-noach merged commit d6a1508 into release-19.0 Sep 4, 2024
204 checks passed
@shlomi-noach shlomi-noach deleted the backport-16637-to-release-19.0 branch September 4, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants