-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tablet-tags/--init_tags
stats
#16695
base: main
Are you sure you want to change the base?
Add tablet-tags/--init_tags
stats
#16695
Conversation
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16695 +/- ##
==========================================
+ Coverage 68.93% 68.95% +0.01%
==========================================
Files 1565 1565
Lines 201553 201560 +7
==========================================
+ Hits 138944 138982 +38
+ Misses 62609 62578 -31 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds good to me, the format in the /metrics output looks okay too.
We don't seem to have any tests for tablet stats. Now may be a good time to add some. |
Description
This PR adds stats for the key/values set by
--init_tags
invttablet
. I assume it's unlikely that a tablet would have enough tags to generate too much metric cardinalityThis allows a user to use this data to query/group tablets in observability tooling
Output example (heavily redacted):
Related Issue(s)
Resolves #16696
Checklist
Deployment Notes